insitro / redun

Yet another redundant workflow engine
https://insitro.github.io/redun/
Apache License 2.0
510 stars 43 forks source link

GCP batch support v2 #68

Closed mattrasmus closed 1 year ago

mattrasmus commented 1 year ago

@msamman Here is a small update to your PR #66 that fills out the rest of the Google Batch example. It also makes a few smaller changes to the executor. Feel free to adopt these changes into your PR.

mattrasmus commented 1 year ago

Looking at that last failing test it looks like we should really drop python3.6 support. We have an internal PR ready to do this.

mattrasmus commented 1 year ago

@MSamman @danielecook

I have now remerged #66 and main into this PR. I've also added some initial tests of the executor to help protect against regressions in future PRs. If these changes look good to you, then we could merge this branch instead of #66, and do the follow up work in smaller future PRs. Let me know what sounds good to you.

MSamman commented 1 year ago

SGTM/LGTM!