insitro / redun

Yet another redundant workflow engine
https://insitro.github.io/redun/
Apache License 2.0
510 stars 43 forks source link

split out version into it's own module #73

Closed MSamman closed 1 year ago

mattrasmus commented 1 year ago

Thanks for submitting this PR. Can you also update setup.py to find the version correctly?

diff --git a/setup.py b/setup.py
index 543a03f..94ada7c 100644
--- a/setup.py
+++ b/setup.py
@@ -46,10 +46,10 @@ def get_version() -> str:
     """
     # Technique from: https://packaging.python.org/guides/single-sourcing-package-version/
     basedir = os.path.dirname(__file__)
-    module_path = os.path.join(basedir, "redun", "__init__.py")
+    module_path = os.path.join(basedir, "redun", "version.py")
     with open(module_path) as infile:
         for line in infile:
-            if line.startswith("__version__"):
+            if line.startswith("version ="):
                 _, version, _ = line.split('"', 2)
                 return version
     assert False, "Cannot find redun package version"
mattrasmus commented 1 year ago

The test error is due to a recent change in an upstream dependency (aibotocore vs botocore) and is unrelated to the current PR. I'll investigate the dependency issue separately.

Thanks!