insitro / redun

Yet another redundant workflow engine
https://insitro.github.io/redun/
Apache License 2.0
510 stars 43 forks source link

Windows compatibility #96

Closed paulduf closed 3 months ago

paulduf commented 3 months ago

Hello,

I'm trying to run redun on my local machine with Windows 10 OS.

Running

python {path_to_anaconda_venv}\Scripts\redun run test.py main

gives me the error

Traceback (most recent call last):
  File "{path_to_anaconda_venv}\Scripts\redun", line 10, in <module>
    client.execute()
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\cli.py", line 916, in execute        
    return args.func(args, extra_args, argv)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\cli.py", line 1487, in run_command   
    scheduler = self.get_scheduler(args, migrate_if_local=True)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\cli.py", line 878, in get_scheduler  
    self.scheduler = setup_scheduler(
                     ^^^^^^^^^^^^^^^^
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\cli.py", line 628, in setup_scheduler
    config = setup_config(config_dir, repo=repo)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\cli.py", line 370, in setup_config   
    config_file = BaseFile(config_path)
                  ^^^^^^^^^^^^^^^^^^^^^
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\file.py", line 1184, in __init__
    self.filesystem: FileSystem = get_filesystem(url=path)
                                  ^^^^^^^^^^^^^^^^^^^^^^^^
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\file.py", line 165, in get_filesystem
    filesystem_class = get_filesystem_class(proto=proto, url=url)
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "{path_to_anaconda_venv}\Lib\site-packages\redun\file.py", line 83, in get_filesystem_class
    return _proto2filesystem_class[proto]
           ~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^
KeyError: 'c'

Is it expected ? Do you test against Windows OS ?

The fact that I had to trick and specify python .../redun to run the program and that no .exe file was created when pip install or conda install in the Scripts folder makes me wonder if Windows is supported at all, in which case it would be better to raise an error than letting the user try to make it.

mattrasmus commented 3 months ago

Hi @paulduf thanks for posting this issue. Unfortunately, redun does not support windows at this time. We'll update our package's OS requirements to make the more explicit. Sorry for the confusion.

paulduf commented 3 months ago

Thanks for your quick reply. I'll give it a chance with a Windows Subsystem for Linux then. You can probably close this issue.