search

insomniachi / Totoro

A Windows 10/11 only application that is a go to for all things anime.
MIT License
217 stars 11 forks source link

site request : kamyroll #10

Closed venkat2305 closed 1 year ago

venkat2305 commented 1 year ago

add kamyroll. https://github.com/kamyroll it scrapes from crunchyroll and it would be a great addition

bachig26 commented 1 year ago

@insomniachi i would suggest add Crunchyroll from consumet api.

https://github.com/consumet/consumet.ts/blob/master/src/providers/anime/crunchyroll.ts

https://github.com/consumet/api.consumet.org/blob/main/src/routes/anime/crunchyroll.ts

venkat2305 commented 1 year ago

Does consumet api has any advantage?

bachig26 commented 1 year ago

Does consumet api has any advantage?

Kamyroll is hosted using US server (only one location), so the content is restricted to what we can watch on US, if some content is exclusive for other location then you can't see.

In case of Consumet API, they host their API in US, Europe, some country in Asia. so, if watch from Europe you can experience the contents that's available in that part and if you use VPN with US server, you can watch US content that's exclusive there, which is highly useful in many ways.

venkat2305 commented 1 year ago

That's not true. I can see many anime that were blocked in my region in crunchyroll using kamyroll.

insomniachi commented 1 year ago

Looks like consumet api was using kamyroll before as crunchyroll, now they have something new, idk if it's still using kamyroll under the hood.

Kamyroll takes location as argument, so it should be able to get everything.

bachig26 commented 1 year ago

Looks like consumet api was using kamyroll before as crunchyroll, now they have something new, idk if it's still using kamyroll under the hood.

Yes, they used Kamyroll as Crunchyroll. After developing their own API for crunchyroll called cronchy, now they have both.

Kamyroll takes location as argument, so it should be able to get everything.

I don't know about it. But I have asked this question to the Kamyroll and Consumet developers last month and they gave this answer.

insomniachi commented 1 year ago

Added Kamyroll. Also added Consumet, but can only use Zoro and animepahe from it at the moment. (It doesn't seem to play audio from animepahe)

image now valid values are only zoro/animepahe but more will be added

you get this dialog by clicking the defaultprovider in settings.

as a part of this change the providers were separated from the main application and they will automatically get updated in the background. so if in the future new providers are added they will be available without updating the app.

venkat2305 commented 1 year ago

Hey, @insomniachi kamyroll just got a DMCA. Could you please add crunchyroll from consumet api?

insomniachi commented 1 year ago

it's already there. image change the provider to crunchyroll

venkat2305 commented 1 year ago

search isn't working. and there's a weird dialog before opening the player. What is it?

https://user-images.githubusercontent.com/55329452/214787649-f9af623a-f838-4515-8d13-e4d3eb91373b.mp4

insomniachi commented 1 year ago

can you give me log files in AppData\Local\Totoro\ApplicationData\Logs. The dialog is, in order to gat Mal Id, i need it to search the opening/ed skip information. also to update anilist/mal to tracking. it's okay if you just close the dialog, (it just won't update tracking/get op/ed timestamps) if it cannot resolve it from title, it asks you to select select from the list.

but something is wrong here, i'll check.

venkat2305 commented 1 year ago

For some anime it is showing a list of anime for some it's empty.

venkat2305 commented 1 year ago

@insomniachi please add English subs for kamyroll Japanese dub.

insomniachi commented 1 year ago

it's already there. image change the provider to crunchyroll

for now, you can do. Change CrunchyrollStreamType to 'dub'. but then it'll only show dubs.

but i'll update it later to show both.

venkat2305 commented 1 year ago

Crunchyroll has dubs for many languages. Also, it would be great to have an option to select sub or dub on the player itself

venkat2305 commented 1 year ago

there are no subtitles. Please add it.

insomniachi commented 1 year ago

You mean for dubs ? i have no idea on how to load external subtitles right now. will add if i ever figure out how to.

venkat2305 commented 1 year ago

For Japanese dub. There are no hard subs and there are no soft subs

insomniachi commented 1 year ago

can you tell which show and episode? so i can check what the api returns.

venkat2305 commented 1 year ago

Demon slayer season 1 episode 1

insomniachi commented 1 year ago

added, closing this. image

venkat2305 commented 1 year ago

Can I post all the bugs related to crunchyroll here?

  1. Can you try to play " the Angel next door spoils me rotten" and "Vinland saga season 2" in crunchyroll. I think there's an issue with the current season anime. I can't play them but it works fine with completed anime.

  2. Recently aired page is empty for crunchyroll. Can you look into this?

insomniachi commented 1 year ago

i'm moving it to new issue. #16