insomniachi / Totoro

A Windows 10/11 only application that is a go to for all things anime.
MIT License
217 stars 11 forks source link

Error while searching. #34

Closed yORmOmi closed 1 year ago

yORmOmi commented 1 year ago

Describe the bug When I try to search for something on the search tab and press entered an error will show.

To Reproduce Steps to reproduce the behavior:

  1. Go to 'Discover > search'
  2. Click on 'search input, and type something in it.'
  3. Press enter button.
  4. See the error.

Expected behavior

System.FormatException: The input string '' was not in a correct format.
   at System.Number.ThrowOverflowOrFormatException(ParsingStatus status, ReadOnlySpan`1 value, TypeCode type)
   at Totoro.Plugins.Anime.AllAnime.Catalog.Search(String query)+MoveNext()
   at Totoro.Plugins.Anime.AllAnime.Catalog.Search(String query)+System.Threading.Tasks.Sources.IValueTaskSource<System.Boolean>.GetResult()
   at System.Linq.AsyncEnumerable.<ToListAsync>g__Core|424_0[TSource](IAsyncEnumerable`1 source, CancellationToken cancellationToken) in /_/Ix.NET/Source/System.Linq.Async/System/Linq/Operators/ToList.cs:line 36
   at System.Linq.AsyncEnumerable.<ToListAsync>g__Core|424_0[TSource](IAsyncEnumerable`1 source, CancellationToken cancellationToken) in /_/Ix.NET/Source/System.Linq.Async/System/Linq/Operators/ToList.cs:line 36

Screenshots image config image

yORmOmi commented 1 year ago

I found a simple fix using "Marin" I also tested it on other stream providers and it did not work including zoro[execept Marin]

insomniachi commented 1 year ago

This was specific to the term you searched "one pi" all anime returns some movies, which doesn't have season or mal id / anilist id

you'll get fix for crash without updating the app. however anime without anilist/mal id is not addressed, that will need an application update when fixed.

yORmOmi commented 1 year ago

This was specific to the term you searched "one pi" all anime returns some movies, which doesn't have season or mal id / anilist id

you'll get fix for crash without updating the app. however anime without anilist/mal id is not addressed, that will need an application update when fixed.

👍 Thanks, also your application is amazing!