insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go

BSD 3-Clause "New" or "Revised" License

710 stars 169 forks source link

dhcpv4/nclient4: switch to github.com/mdlayher/packet #461

Closed mdlayher closed 2 years ago

mdlayher commented 2 years ago

Signed-off-by: Matt Layher mdlayher@gmail.com

I made and tagged a new library https://github.com/mdlayher/packet for Linux only, see the README for rationale.

Unfortunately this means we also drop support for *BSD again, but AFAICT that code path in package raw was actually broken because the "LinuxSockDGRAM" option never worked on BSD.

codecov[bot] commented 2 years ago

Codecov Report

Merging #461 (33a7075) into master (3c283ff) will not change coverage. The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master     #461   +/-   ##
=======================================
  Coverage   67.42%   67.42%           
=======================================
  Files          90       90           
  Lines        3758     3758           
=======================================
  Hits         2534     2534           
  Misses       1053     1053           
  Partials      171      171

Flag	Coverage Δ
integtests	`∅ <ø> (∅)`
unittests	`67.42% <66.66%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dhcpv4/nclient4/conn_unix.go	`54.90% <66.66%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c283ff...33a7075. Read the comment docs.

insomniacslk commented 2 years ago

CC @hugelgupf since this touches nclient

mdlayher commented 2 years ago

Hi there @insomniacslk and @hugelgupf! Any further thoughts? Like I mentioned, I think this was already broken on BSD so I would encourage moving forward with this as an improvement. Dedicated work will be necessary to make a production ready packet sockets equivalent for *BSD, and I lack that expertise at the moment.

mdlayher commented 2 years ago

Ping @insomniacslk.

rminnich commented 2 years ago

I really wish we would not move to a "linux only" world. I've been battling to get this package working on darwin for years, and it's a shame to see a move away from portability.

rminnich commented 2 years ago

I've asked a BSD friend for thoughts on this change, if there is a way forward.

mdlayher commented 2 years ago

See my first comment:

AFAICT that code path in package raw was actually broken because the "LinuxSockDGRAM" option never worked on BSD.

But given the lack of movement here, I'm going to close this out and let you all reevaluate. Just note that raw is unmaintained. Thanks.