yunginnanet commented 2 years ago

We are decoding a sequence of bytes into a *DHCPv4 type, not the other way around.

codecov[bot] commented 2 years ago

Codecov Report

Merging #465 (b8c47c3) into master (12fbdcb) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   67.45%   67.45%           
=======================================
  Files          90       90           
  Lines        3767     3767           
=======================================
  Hits         2541     2541           
  Misses       1054     1054           
  Partials      172      172

Flag	Coverage Δ
integtests	`∅ <ø> (∅)`
unittests	`67.45% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dhcpv4/dhcpv4.go	`74.04% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12fbdcb...b8c47c3. Read the comment docs.

pmazzini commented 2 years ago

Thanks for the contribution. Please sign the commit: https://github.com/insomniacslk/dhcp/pull/465/checks?check_run_id=6279417751

yunginnanet commented 2 years ago

Done

insomniacslk / dhcp

Documentation: Description is inverse of reality #465

Codecov Report