insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go
BSD 3-Clause "New" or "Revised" License
685 stars 168 forks source link

Adding support for new juniper format #494

Closed name29 closed 1 year ago

name29 commented 1 year ago

Adding support for new juniper format

pmazzini commented 1 year ago

Tests are failing:

    ztp_test.go:93: 
            Error Trace:    ztp_test.go:93
            Error:          Not equal: 
                            expected: &ztpv4.VendorData{VendorName:"Juniper", Model:"D12345", Serial:"D12345"}
                            actual  : &ztpv4.VendorData{VendorName:"Juniper", Model:"ttttt-ttt", Serial:"D12345"}
codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (86f5cd5) 72.84% compared to head (67c5482) 72.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #494 +/- ## ========================================== + Coverage 72.84% 72.88% +0.04% ========================================== Files 90 90 Lines 5719 5728 +9 ========================================== + Hits 4166 4175 +9 Misses 1381 1381 Partials 172 172 ``` | [Impacted Files](https://codecov.io/gh/insomniacslk/dhcp/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac) | Coverage Δ | | |---|---|---| | [dhcpv4/ztpv4/ztp.go](https://codecov.io/gh/insomniacslk/dhcp/pull/494?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY0L3p0cHY0L3p0cC5nbw==) | `97.02% <100.00%> (+0.29%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.