insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go
BSD 3-Clause "New" or "Revised" License
685 stars 168 forks source link

Define type Serializable #495

Open hugelgupf opened 1 year ago

hugelgupf commented 1 year ago

Toward lazy option parsing -- which I'm not 100% sure should be applied everywhere anymore, but at least should be applied to vendor options for ease of use of the library.

Bit of test coverage improvement here, too.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 87.30% and project coverage change: +0.01 :tada:

Comparison is base (3e45eea) 72.88% compared to head (50801df) 72.90%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #495 +/- ## ========================================== + Coverage 72.88% 72.90% +0.01% ========================================== Files 90 90 Lines 5728 5728 ========================================== + Hits 4175 4176 +1 Misses 1381 1381 + Partials 172 171 -1 ``` | [Impacted Files](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac) | Coverage Δ | | |---|---|---| | [dhcpv6/duid.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L2R1aWQuZ28=) | `84.61% <ø> (ø)` | | | [dhcpv6/types.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L3R5cGVzLmdv) | `91.66% <ø> (ø)` | | | [dhcpv6/dhcpv6message.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L2RoY3B2Nm1lc3NhZ2UuZ28=) | `78.75% <76.92%> (-0.06%)` | :arrow_down: | | [dhcpv6/dhcpv6relay.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L2RoY3B2NnJlbGF5Lmdv) | `85.09% <82.35%> (-0.33%)` | :arrow_down: | | [dhcpv6/options.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L29wdGlvbnMuZ28=) | `92.48% <83.33%> (-0.89%)` | :arrow_down: | | [dhcpv6/dhcpv6.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L2RoY3B2Ni5nbw==) | `77.31% <100.00%> (+3.59%)` | :arrow_up: | | [dhcpv6/option\_iaaddress.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L29wdGlvbl9pYWFkZHJlc3MuZ28=) | `92.50% <100.00%> (-0.53%)` | :arrow_down: | | [dhcpv6/option\_iapd.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L29wdGlvbl9pYXBkLmdv) | `94.00% <100.00%> (-0.34%)` | :arrow_down: | | [dhcpv6/option\_iaprefix.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L29wdGlvbl9pYXByZWZpeC5nbw==) | `94.64% <100.00%> (-0.19%)` | :arrow_down: | | [dhcpv6/option\_nontemporaryaddress.go](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY2L29wdGlvbl9ub250ZW1wb3JhcnlhZGRyZXNzLmdv) | `94.54% <100.00%> (-0.29%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/insomniacslk/dhcp/pull/495?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.