insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go
BSD 3-Clause "New" or "Revised" License
685 stars 168 forks source link

dhcpv4: change `NewRenewFromOffer` to `NewRenewFromAck` #498

Closed twelho closed 1 year ago

twelho commented 1 year ago

Minor fixup for https://github.com/insomniacslk/dhcp/pull/469.

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@b11966a). Click here to learn what that means. Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 94cdde9 differs from pull request most recent head 26f85b3. Consider uploading reports for the commit 26f85b3 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #498 +/- ## ========================================= Coverage ? 72.90% ========================================= Files ? 90 Lines ? 5732 Branches ? 0 ========================================= Hits ? 4179 Misses ? 1381 Partials ? 172 ``` | [Impacted Files](https://codecov.io/gh/insomniacslk/dhcp/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac) | Coverage Δ | | |---|---|---| | [dhcpv4/dhcpv4.go](https://codecov.io/gh/insomniacslk/dhcp/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY0L2RoY3B2NC5nbw==) | `75.09% <100.00%> (ø)` | | | [dhcpv4/nclient4/lease.go](https://codecov.io/gh/insomniacslk/dhcp/pull/498?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY0L25jbGllbnQ0L2xlYXNlLmdv) | `46.15% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pmazzini commented 1 year ago

Thanks