insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go
BSD 3-Clause "New" or "Revised" License
710 stars 169 forks source link

Adding Arista port-channel naming, correct line index #500

Closed RobelK1 closed 1 year ago

RobelK1 commented 1 year ago

This change will add interface Arista port-channel support for DHCP replay function

pmazzini commented 1 year ago

Please add unit tests with example circuits in parse_circuitid_test.go.

pmazzini commented 1 year ago

Please sign the commit:

To add your Signed-off-by line to every commit in this branch:

Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin master

https://github.com/insomniacslk/dhcp/pull/500/checks?check_run_id=12529886931

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (74ae03f) 72.77% compared to head (083d360) 72.77%.

:exclamation: Current head 083d360 differs from pull request most recent head 74e2714. Consider uploading reports for the commit 74e2714 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #500 +/- ## ======================================= Coverage 72.77% 72.77% ======================================= Files 90 90 Lines 5742 5742 ======================================= Hits 4179 4179 Misses 1391 1391 Partials 172 172 ``` | [Impacted Files](https://codecov.io/gh/insomniacslk/dhcp/pull/500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac) | Coverage Δ | | |---|---|---| | [dhcpv4/ztpv4/parse\_circuitid.go](https://codecov.io/gh/insomniacslk/dhcp/pull/500?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-ZGhjcHY0L3p0cHY0L3BhcnNlX2NpcmN1aXRpZC5nbw==) | `85.00% <ø> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

pmazzini commented 1 year ago

Tests are failing:

Error: dhcpv4/ztpv4/parse_circuitid_test.go:61:51: cannot use "Port-Channel10" (untyped string constant) as *CircuitID value in struct literal
FAIL    github.com/insomniacslk/dhcp/dhcpv4/ztpv4 [build failed]
Error: dhcpv4/ztpv4/parse_circuitid_test.go:61:75: cannot use &CircuitID{…} (value of type *CircuitID) as type string in struct literal
Error: dhcpv4/ztpv4/parse_circuitid_test.go:92:51: cannot use "Port-Channel10" (untyped string constant) as []byte value in struct literal
pmazzini commented 1 year ago

DCO is failing:

https://github.com/insomniacslk/dhcp/pull/500/checks?check_run_id=12553255492