Closed RobelK1 closed 1 year ago
Please add unit tests with example circuits in parse_circuitid_test.go
.
Please sign the commit:
To add your Signed-off-by line to every commit in this branch:
Ensure you have a local copy of your branch by [checking out the pull request locally via command line](https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/checking-out-pull-requests-locally).
In your local branch, run: git rebase HEAD~1 --signoff
Force push your changes to overwrite the branch: git push --force-with-lease origin master
https://github.com/insomniacslk/dhcp/pull/500/checks?check_run_id=12529886931
Patch and project coverage have no change.
Comparison is base (
74ae03f
) 72.77% compared to head (083d360
) 72.77%.:exclamation: Current head 083d360 differs from pull request most recent head 74e2714. Consider uploading reports for the commit 74e2714 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Tests are failing:
Error: dhcpv4/ztpv4/parse_circuitid_test.go:61:51: cannot use "Port-Channel10" (untyped string constant) as *CircuitID value in struct literal
FAIL github.com/insomniacslk/dhcp/dhcpv4/ztpv4 [build failed]
Error: dhcpv4/ztpv4/parse_circuitid_test.go:61:75: cannot use &CircuitID{…} (value of type *CircuitID) as type string in struct literal
Error: dhcpv4/ztpv4/parse_circuitid_test.go:92:51: cannot use "Port-Channel10" (untyped string constant) as []byte value in struct literal
This change will add interface Arista port-channel support for DHCP replay function