search

insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go
BSD 3-Clause "New" or "Revised" License
685 stars 168 forks source link

os instead of ioutil #502

Closed pmazzini closed 10 months ago

codecov[bot] commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (01274d6) 72.77% compared to head (cb25548) 72.77%.

:exclamation: Current head cb25548 differs from pull request most recent head 4ef8a41. Consider uploading reports for the commit 4ef8a41 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #502 +/- ## ======================================= Coverage 72.77% 72.77% ======================================= Files 91 91 Lines 5777 5777 ======================================= Hits 4204 4204 Misses 1398 1398 Partials 175 175 ``` | [Files Changed](https://app.codecov.io/gh/insomniacslk/dhcp/pull/502?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac) | Coverage Δ | | |---|---|---| | [netboot/netconf.go](https://app.codecov.io/gh/insomniacslk/dhcp/pull/502?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=insomniac#diff-bmV0Ym9vdC9uZXRjb25mLmdv) | `48.23% <0.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

insomniacslk commented 10 months ago

This looks good to me. Can you just squash the 6 commits into 1 before merging?

pmazzini commented 10 months ago

Can you just squash the 6 commits into 1 before merging?

Should be done.