search

insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go
BSD 3-Clause "New" or "Revised" License
685 stars 168 forks source link

Add option IPv6OnlyPreferred (RFC 8925) #524

Closed candlerb closed 4 months ago

candlerb commented 4 months ago

This DHCP option is needed to support https://github.com/coredhcp/coredhcp/pull/170

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 73.21%. Comparing base (ca2dc33) to head (fb14ecd).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #524 +/- ## ========================================== + Coverage 73.07% 73.21% +0.13% ========================================== Files 80 80 Lines 5059 5073 +14 ========================================== + Hits 3697 3714 +17 + Misses 1219 1216 -3 Partials 143 143 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pmazzini commented 4 months ago

Don't you want to add parsing for this option as well to avoid having to deal with OptGeneric in the coredhcp code?

candlerb commented 4 months ago

Good point. Helpers added, and tested with a corresponding patched coredhcp.

candlerb commented 4 months ago

I think this is in shape for a recheck now, thanks.

candlerb commented 4 months ago

Many thanks. I'm good for you to merge this, and #525.

candlerb commented 4 months ago

Thank you!