Closed candlerb closed 4 months ago
Attention: Patch coverage is 96.77419%
with 1 lines
in your changes are missing coverage. Please review.
Project coverage is 73.35%. Comparing base (
3c11703
) to head (45ea332
).
Files | Patch % | Lines |
---|---|---|
dhcpv4/option_autoconfigure.go | 96.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ready for review
I have changed the AutoConfigure() helper to return (value, bool) instead of (value, error). I do need this one for coredhcp.
Please could you kick off the CI, and if it's happy, I'm good to merge this now.
This isn't really a fully-fledged pull request: I'm seeking advice on how best to expose the option AutoConfigure from RFC 2563.
What the proposed patch does is implement a Byte option, based on Uint16 from
dhcpv4/option_maximum_dhcp_message_size.go
However, other possibilities would be:
OptClientIdentifier()
indhcpv4/option_misc.go
Based on the registry, some other examples of single-byte DHCP options are: