Make Option 82 come last

insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go

BSD 3-Clause "New" or "Revised" License

685 stars 168 forks source link

Make Option 82 come last #535

Closed michaelharo closed 2 months ago

michaelharo commented 2 months ago

https://datatracker.ietf.org/doc/html/rfc3046#section-2.1 states:

A DHCP relay agent adding a Relay Agent Information field SHALL add
it as the last option (but before 'End Option' 255, if present) in
the DHCP options field of any recognized BOOTP or DHCP packet
forwarded from a client to a server.

pmazzini commented 2 months ago

Can you sign the commit?

https://github.com/insomniacslk/dhcp/pull/535/checks?check_run_id=25338914949

michaelharo commented 2 months ago

I think I did that.

insomniacslk commented 2 months ago

~~The code looks good to me but I can't figure out why there is only one check being run.~~ EDIT: figured out, it's a new thing that I didn't know, I had to explicitly enable the test run