search

insomniacslk / dhcp

DHCPv6 and DHCPv4 packet library, client and server written in Go
BSD 3-Clause "New" or "Revised" License
685 stars 168 forks source link

Improve support for renewal and rebinding options #536

Closed michaelharo closed 3 weeks ago

michaelharo commented 1 month ago

I'm looking for some feedback on this request. For example, I couldn't decide if the functions should include "Value" in their name. "Time Value" is part of the name of the option in the RFC.

dhcpv4.OptRenewTimeValue(...) or dhcpv4.OptRenewTime(...)

Also the access functions on DHCPv4 already exist and are named like IPAddressRenewalTime. Would it be more clear if the option creation helpers were named with an IPAddress prefix so like OptIPAddressRenewalTime (also renew vs renewal)?

michaelharo commented 3 weeks ago

What's the next step for getting this request merged?