search

insomniacslk / dublin-traceroute

Dublin Traceroute is a NAT-aware multipath tracerouting tool
https://dublin-traceroute.net
BSD 2-Clause "Simplified" License
253 stars 56 forks source link

Enhancement - TCP and ICMP probes needs to be implemented #74

Closed anburhce closed 4 years ago

anburhce commented 4 years ago

Hi Andrea,

I would like you to implement TCP and ICMP on dublin-traceroute.

insomniacslk commented 4 years ago

Hi @anburhce , this should be an issue rather than a pull request. TCP probes are tracked at https://github.com/insomniacslk/dublin-traceroute/issues/42 , I'm not sure if I will ever implement ICMP probes as I see limited value in them (but I'm not against someone else implementing it).

However I don't have much spare time at the moment, so I cannot make a promise on when this will be done. Again, if you feel you could implement it yourself, I'll be happy to review.

insomniacslk commented 4 years ago

I'll close this PR, feel free to open an issue for ICMP probes if you plan to implement them. Thanks!