search

insomniacslk / irc-slack

IRC-to-Slack gateway
BSD 3-Clause "New" or "Revised" License
192 stars 19 forks source link

[tools/autotoken] Ensure defers are called #154

Closed insomniacslk closed 3 years ago

insomniacslk commented 3 years ago

Due to the use of log.Fatalf it was possible for defers not to run in case of errors, which had the consequence of leaving headless chrome instancess running in background even after completion.

Signed-off-by: Andrea Barberio insomniac@slackware.it

codecov[bot] commented 3 years ago

Codecov Report

Merging #154 (eb146fc) into master (18bc1a9) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #154   +/-   ##
======================================
  Coverage    7.14%   7.14%           
======================================
  Files           8       8           
  Lines         952     952           
======================================
  Hits           68      68           
  Misses        881     881           
  Partials        3       3
Flag Coverage Δ
unittest 7.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18bc1a9...eb146fc. Read the comment docs.