search

insomniacslk / irc-slack

IRC-to-Slack gateway
BSD 3-Clause "New" or "Revised" License
195 stars 19 forks source link

Removed IrcContext.GetUsers #156

Closed insomniacslk closed 3 years ago

insomniacslk commented 3 years ago

This function is redundant. Used Users.Fetch directly instead.

Signed-off-by: Andrea Barberio insomniac@slackware.it

codecov[bot] commented 3 years ago

Codecov Report

Merging #156 (d6a836d) into master (67889a8) will increase coverage by 0.02%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #156      +/-   ##
=========================================
+ Coverage    7.14%   7.16%   +0.02%     
=========================================
  Files           8       8              
  Lines         952     949       -3     
=========================================
  Hits           68      68              
+ Misses        881     878       -3     
  Partials        3       3
Flag Coverage Δ
unittest 7.16% <0.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/ircslack/event_handler.go 0.00% <0.00%> (ø)
pkg/ircslack/irc_context.go 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 67889a8...d6a836d. Read the comment docs.