insou22 / mipsy

Education-focused MIPS Emulator written in Rust.
86 stars 13 forks source link

Add labels to mipsy_web data view #267

Closed Dylan-Brotherston closed 2 years ago

joooooooooooooooooooooooooooooooooooosh commented 2 years ago

doesn't need to be in this PR but adding a button somewhere to toggle the labels showing in the rendered data segment itself rather than just hovering on tooltip would be nice

Dylan-Brotherston commented 2 years ago

This has a massive performance overhead and might want to be rolled back and rethought.

joooooooooooooooooooooooooooooooooooosh commented 2 years ago

wait really? can you give examples of where this is noticeable? The only thing added I can see that could have a noticeable perf impact is the label iteration on every byte, but this could be rethought easily by creating a HashMap once before the loops start

Dylan-Brotherston commented 2 years ago

It's hard to do an exact benchmark. But it is noticeably slower.

If you are actively viewing the data tab it is extremely obvious it has slowed down.

joooooooooooooooooooooooooooooooooooosh commented 2 years ago

I'm not noticing anything? Stepping through commands that modify the data tab and/or position of $sp/$fp affect the data tab instantaneously and even running two_powerful to completion updates without issue.