Adding vpn connection resource

inspec / inspec-aws

InSpec AWS Resource Pack https://www.inspec.io/

Other

136 stars 105 forks source link

Closed Rohit1509 closed 2 years ago

Rohit1509 commented 2 years ago

Adding vpn connection resource

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Please fill box or appropriate ([x]) or mark N/A.

[ ] New functionality includes integration tests/controls
[ ] New Terraform resources
[ ] Documentation provided or updated for resources
[ ] All Integration Tests pass
[ ] All Unit Tests pass
[ ] rake lint passes
[ ] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco

netlify[bot] commented 2 years ago

Name	Link
Latest commit	d7abce729de83fc53e3fcfb01c4ba0cbccf8f815
Latest deploy log	https://app.netlify.com/sites/inspec-aws/deploys/62fb90cbe678c0000833d4c0
Deploy Preview	https://deploy-preview-930--inspec-aws.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

soumyo13 commented 2 years ago

@Rohit1509 Please add the integration test and the documentation.

soumyo13 commented 2 years ago

Here only singular resource is added. Can you please add the plural resource also.

Rohit1509 commented 2 years ago

Here only singular resource is added. Can you please add the plural resource also.

Plural resource already exists

Rohit1509 commented 2 years ago

@soumyo13 all the requested changes have been made. Thanks!

Rohit1509 commented 2 years ago

Hi @soumyo13 , can you please look into why the PR validation is failing ? It looks to be out of scope of this PR. Thanks!