inspec / inspec-aws

InSpec AWS Resource Pack https://www.inspec.io/
Other
136 stars 106 forks source link

Fix aws_s3_ bucket_policy #to_s method to reflect object #946

Closed vsuzdaltsev closed 2 years ago

vsuzdaltsev commented 2 years ago

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Please fill box or appropriate ([x]) or mark N/A.

netlify[bot] commented 2 years ago

Deploy Preview for inspec-aws ready!

Name Link
Latest commit 1a112b26047b0646a05c6295a6eee40518a9df68
Latest deploy log https://app.netlify.com/sites/inspec-aws/deploys/6329d4cc5ce90d00091ea855
Deploy Preview https://deploy-preview-946--inspec-aws.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

vsuzdaltsev commented 2 years ago

This way it may seem like a bit more readable

image

then

image
vsuzdaltsev commented 2 years ago

Also I would be happy to understand why only the first element of a policy statement is parsed here

image
soumyo13 commented 2 years ago

Also I would be happy to understand why only the first element of a policy statement is parsed here image

This we have to work on!