inspec / inspec-aws

InSpec AWS Resource Pack https://www.inspec.io/
Other
133 stars 106 forks source link

Added support for aws waf v2 #974

Open robertdeheer opened 9 months ago

robertdeheer commented 9 months ago

Description

Please describe what this change achieves. Ensure you have read the Contributing to InSpec AWS document before submitting.

Issues Resolved

List any existing issues this PR resolves, or any Discourse or StackOverflow discussion that's relevant

Check List

Please fill box or appropriate ([x]) or mark N/A.

netlify[bot] commented 9 months ago

Deploy Preview for inspec-aws canceled.

Name Link
Latest commit 4be0985783769ac20a1e1f6db56e85cea34cb04d
Latest deploy log https://app.netlify.com/sites/inspec-aws/deploys/6507ad291288340008ee1db3
aaronlippold commented 6 months ago

Given our recent updates to main and the train-aws v0.4.2 release you should be able to pull in upstream/main and your PR should hopefully pass to the next stage as the aws_sdk_wafv2 gem is now in train-aws.

aaronlippold commented 6 months ago

If you want to get this passing for now - add the needed gem to the Gemfile and this should get moving again.

aaronlippold commented 6 months ago

Documentation for the resources - which is likely a 'mostly copy' from the v1 docs - seems to be missing.