Implement lookup for full Vault paths and secrets

thheinen commented 4 years ago

In our experience, Vault secrets are rarely stored on a per-profile level but more as some sort of global configuration data. As the current plugin implementation does not allow access to those paths, this PR was created.

Description

The usual way of working is not changed. If the input name starts with a forward slash, this is taken as an indicator for a fully specified path. In that case the last part of the input is treated as the key and everything before as the path.

Related Issue

Lookup for arbitrary Vault secret paths #29

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New content (non-breaking change)
[ ] Breaking change (a content change which would break existing functionality or processes)

Checklist:

[x] I have read the CONTRIBUTING document.

james-stocks commented 4 years ago

@tecracer-theinen thank you very much, this looks great! I left 2 comments on the documentation. I need to double check if someone from Chef's doc teams needs to +1 this - generally they do need to review doc changes; but this is a plugin. I'll get back to you.

thheinen commented 4 years ago

Great additions, thank you :)

thheinen commented 4 years ago

Small ping about this. I merged the doc changes on GitHub directly, thus the DCO error.

thheinen commented 4 years ago

Anything I can do to advance this one?

thheinen commented 4 years ago

No worries. As gentle punishment, I just created the follow-up PR to improve usage with Test Kitchen ;)

inspec / inspec-vault