search

inspec / inspec

InSpec: Auditing and Testing Framework
http://inspec.io
Other
2.86k stars 682 forks source link

Reporter plugins do not work when multiple suites are tested in Kitchen #5289

Open fozboz opened 4 years ago

fozboz commented 4 years ago

There is an issue with the way that Inspec handles reporter plugins when there are multiple suites being tested in Kitchen. This error https://github.com/inspec/inspec/blob/master/lib/inspec/plugin/v2/registry.rb#L75 is thrown on all but the first suite, because a unique instance of the Activator class is being created for every suite.

If I remove the guard in Inspec::Plugin::V2::Registry.find_activator that ensures only one activator has been returned, my tests run fine.

I'm thinking to make a PR that checks if the Activator instance for a particular plugin has already been instantiated. If I do that, I don't see the value in having the guard in find_activator. I could remove the guard altogether, and return .first Activator; I don't think it really matters which Activator instance is used.

Aha! Link: https://chef.aha.io/features/SH-402

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We value your input and contribution. Please leave a comment if this issue still affects you.