enabling default backend cache

inspec / kitchen-inspec

Test-Kitchen Plugin for InSpec

Other

109 stars 58 forks source link

enabling default backend cache #264

Closed i5pranay93 closed 3 years ago

i5pranay93 commented 3 years ago

Signed-off-by: Pranay Singh i5singh.pranay@gmail.com

Description

kitchen-inspec the default for backend_cache is disabled so running test cases (against a windows 2016 instance) without cache enabled is taking more time than usual.

Adding backend_cache: true (enabled) will improve performance.

Issues Resolved

https://github.com/inspec/kitchen-inspec/issues/212

Check List

[x] New functionality includes tests
[x] All tests pass
[x] All commits have been signed-off for the Developer Certificate of Origin. See https://github.com/chef/chef/blob/master/CONTRIBUTING.md#developer-certification-of-origin-dco
[x] PR title is a worthy inclusion in the CHANGELOG

clintoncwolfe commented 3 years ago

Hey, sorry this sat for so long without a review - the code change looks good, but there should be an update to the README.md as well, documenting the new setting. Once that's in and has been reviewed, this should be good to go!

andrealai75 commented 3 years ago

II think caching the commands executions by default is not the right call and it is going to confuse people. This is the kind of change that someone would enable when looking to optimise the tests. Also all those that have been creating hundreds of projects without caching have now to review all of them making sure the test is still correct or change the kitchen.yaml

myii commented 2 years ago

Following on from https://github.com/inspec/kitchen-inspec/issues/212#issuecomment-881950866, I do have a suggestion: the documentation should be improved to explain why you might need to disable the backend cache, such as the situation of retrying tests (while waiting for system services to start up), as explained in the linked comment.