Prevent Cisco devices being detected as Arista

[trickyearlobe]

• Some Cisco devices are being mis-detected as Arista devices from show version command
• Added a conditional to the Arista declare_instance to make sure that calls to show version contain Arista

Signed-off-by: Richard Nixon richard.nixon@btinternet

Description

When running inspec detect -t ssh://nexus001 against a virtual Nexus 9300 (NXOS) the platform was being mis-detected as Arista EOS with no version number.

After applying this bugfix, virtual Nexus and virtual Arista devices are correctly detected.

Type of change

• [x] Bug fix (non-breaking change which fixes an issue)
• [ ] New content (non-breaking change)
• [ ] Breaking change (a content change which would break existing functionality or processes)

Checklist:

• [x] I have read the CONTRIBUTING document.

[chef-expeditor[bot]]

Hello trickyearlobe! Thanks for the pull request!

Here is what will happen next:

1. Your PR will be reviewed by the maintainers.
2. Possible Outcomes a. If everything looks good, one of them will approve it, and your PR will be merged. b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner. c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!