Fix Cisco Nexus version detection - Githubissues

inspec / train

Transport Interface to unify communication over SSH, WinRM, and friends.

Apache License 2.0

119 stars 87 forks source link

Fix Cisco Nexus version detection #737

Closed trickyearlobe closed 1 year ago

trickyearlobe commented 2 years ago

The format of the output from show version has changed in Cisco NXOS 9.3 and requires a different regex to match it.

Tested on 9.3(10) virtual Nexus 9300

Signed-off-by: Richard Nixon richard.nixon@btinternet

Description

Added a new regex to extract the version number for Cisco Nexus switches

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New content (non-breaking change)
[ ] Breaking change (a content change which would break existing functionality or processes)

Checklist:

[x] I have read the CONTRIBUTING document.

chef-expeditor[bot] commented 2 years ago

Hello trickyearlobe! Thanks for the pull request!

Here is what will happen next:

Your PR will be reviewed by the maintainers.
Possible Outcomes a. If everything looks good, one of them will approve it, and your PR will be merged. b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner. c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!