Close SSH channels on close event

inspec / train

Transport Interface to unify communication over SSH, WinRM, and friends.

Apache License 2.0

119 stars 87 forks source link

Close SSH channels on close event #780

Closed thheinen closed 4 months ago

thheinen commented 5 months ago

Description

Fix hanging train if all sessions closed but channels still active.

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New content (non-breaking change)
[ ] Breaking change (a content change which would break existing functionality or processes)

Checklist:

[x ] I have read the CONTRIBUTING document.

chef-expeditor[bot] commented 5 months ago

Hello thheinen! Thanks for the pull request!

Here is what will happen next:

Your PR will be reviewed by the maintainers.
Possible Outcomes a. If everything looks good, one of them will approve it, and your PR will be merged. b. The maintainer may request follow-on work (e.g. code fix, linting, etc). We would encourage you to address this work in 2-3 business days to keep the conversation going and to get your contribution in sooner. c. Cases exist where a PR is neither aligned to Chef InSpec's product roadmap, or something the team can own or maintain long-term. In these cases, the maintainer will provide justification and close out the PR.

Thank you for contributing!

Vasu1105 commented 4 months ago

@thheinen Could you please rebase this branch with main?

rahulgoel1 commented 4 months ago

@Vasu1105 @clintoncwolfe Can this PR be merged if the pipeline is passing and has been reviewed?

Vasu1105 commented 4 months ago

@thheinen This branch seems to be not rebased correctly. It is bringing the changes which are already merged for example bumping of version, removal of ruby 3.0 support and changelog changes should not be part of this PR.

thheinen commented 4 months ago

Sigh. Apologies, I messed that up. Will try to address this asap. Thanks for checking