search

inspect-js / is-string

Is this value a JS String object or primitive? This module works cross-realm/iframe, and despite ES6 @@toStringTag.
MIT License
20 stars 3 forks source link

indentation using tabs #4

Closed Sanderand closed 7 years ago

Sanderand commented 7 years ago

I think that typings will add an extra value to your repository. nobody will want to install two dependencies for a single function that checks for a string value. I also doubt that it's extremely likely that the function name isString is going to change a lot and even if it will maintaining the typings for that one function is almost no effort at all. your call.

ljharb commented 7 years ago

Since I don't use Typescript, I'm quite certain that I'll break the type definitions unintentionally. I'm told the standard way in the Typescript to add typings is to use DefinitelyTyped (which has types for many many other modules), rather than adding typings to individual repos, which I mentioned when I closed #3.