inspect-js / object-inspect

string representations of objects in node and the browser
MIT License
142 stars 36 forks source link

Optimize npm build #33

Closed havenchyk closed 4 years ago

havenchyk commented 4 years ago

We don't need to ship tests and other project specific files to users

codecov[bot] commented 4 years ago

Codecov Report

Merging #33 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   98.02%   98.02%           
=======================================
  Files           2        2           
  Lines         253      253           
  Branches       98       98           
=======================================
  Hits          248      248           
  Misses          5        5           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 900d3d8...4271dc0. Read the comment docs.

havenchyk commented 4 years ago

@ljharb I appreciate your fast reaction on this PR, but could you please clarify this statement. Where did it come from?

Tests should be published in every package

https://github.com/isaacs/node-glob/blob/master/package.json#L11-L15 https://github.com/tapjs/node-tap/blob/master/package.json#L95-L100

funny 😄

ljharb commented 4 years ago

From my personal philosophical beliefs, shared by many in the node ecosystem at one time, that npm explore foo && npm install && npm test should always work.

The creator of npm isn't the arbiter of how npm should be used, so I'm not sure why it's particularly funny.

havenchyk commented 4 years ago

Well, I got your point of view, you’re a maintainer and it’s up to you to decide, as for me, your arguments don’t make sense, tests should pass if you go to npm repo packageName, do git clone, npm or yarn install and run test from scripts. Copying over and over useless for end user files - in different situation I would say that you’re paid by cloud provider, because packages with docs, tests and other not really needed files are installed thousands times at CI every day.

Anyhow, I appreciate that you found time to answer me and explain your position.

Best regards

ljharb commented 4 years ago

Git and github aren't immutable, though, and could disappear - and everyone doesn't always have internet at the time they want to do that. However, npm packages are immutable, and can easily be backed up in a local or private registry.