inspect-js / object-inspect

string representations of objects in node and the browser
MIT License
142 stars 36 forks source link

fix some bugs, close #41 #42

Closed idranme closed 1 year ago

idranme commented 1 year ago

Fixes #41

Other: feat: add dts chore: upgrade dep

idranme commented 1 year ago

@ljharb PTAL

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.02% // Head: 90.80% // Decreases project coverage by -4.22% :warning:

Coverage data is based on head (ae094d9) compared to base (66a19b3). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #42 +/- ## ========================================== - Coverage 95.02% 90.80% -4.23% ========================================== Files 2 2 Lines 342 337 -5 Branches 147 145 -2 ========================================== - Hits 325 306 -19 - Misses 17 31 +14 ``` | [Impacted Files](https://codecov.io/gh/inspect-js/object-inspect/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspect-js) | Coverage Δ | | |---|---|---| | [index.js](https://codecov.io/gh/inspect-js/object-inspect/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspect-js#diff-aW5kZXguanM=) | `90.77% <100.00%> (-4.25%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspect-js). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspect-js)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

idranme commented 1 year ago

Thanks for the review. I agree with your thoughts. This PR should be closed.