search

inspectIT / inspectit-ocelot

inspectIT Ocelot - Java agent for collecting application performance, tracing and behavior data
http://www.inspectit.rocks/
Apache License 2.0
204 stars 69 forks source link

feat: download one config file or multiple config files compressed #1439

Closed marcel-haag closed 2 years ago

marcel-haag commented 2 years ago

This change is Reviewable

marcel-haag commented 2 years ago

components/inspectit-ocelot-configurationserver-ui/src/functions/export-selection.function.js line 27 at r2 (raw file):

Previously, MariusBrill (Marius Brill) wrote…
With your code below and the function "fetchSelectedFile" from actions.js we now have some doubled code. How about refactoring "fetchSelectedFile" into two methods so you can reuse the logic? Maybe we can have a short call about this

refactored the code to outsource the request via axios for fetching single file and directories

marcel-haag commented 2 years ago

components/inspectit-ocelot-configurationserver-ui/src/functions/export-selection.function.js line 69 at r2 (raw file):

Previously, MariusBrill (Marius Brill) wrote…
Here again you have some doubled logic - let's just add this to our discussion :)

Done.