search

inspectIT / inspectit-ocelot

inspectIT Ocelot - Java agent for collecting application performance, tracing and behavior data
http://www.inspectit.rocks/
Apache License 2.0
204 stars 69 forks source link

Add settings and info for developing UI in IntelliJ #1496

Closed aaronweissler closed 2 years ago

aaronweissler commented 2 years ago

This change is Reviewable

aaronweissler commented 2 years ago

Some tests seem to be failing.

Those agent tests have been failing seemingly randomly for a small while now. We still will investigate that further, but it's definitely not related to this PR, since there are no changes to Java code or directly related things in here at all (which also was my motivation for adding additional ignore paths for the workflow in #1497 that you also reviewed ^^)

Also, you could still get rid of the warnings. Looks good apart from the tests however, so you decide :)

If you mean the warnings seen in Files Changed, they are also not related to this PR's changes, I'm not sure why GitHub is showing them for those two files.

heiko-holz commented 2 years ago

components/inspectit-ocelot-configurationserver-ui/README.md line 33 at r2 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…
what does `yarn format:write` do as compared to `yarn lint --fix`? Is it recommended to run `eslint --fix` on save?

(addendum: with current version of IntelliJ, we can use Tools.Actions on Save and check Run eslint --fix: image.png