search

inspectIT / inspectit-ocelot

inspectIT Ocelot - Java agent for collecting application performance, tracing and behavior data
http://www.inspectit.rocks/
Apache License 2.0
204 stars 69 forks source link

Closes #1495 - improve the behavior when agent commands fail (or are not available) due to missing configuration - frontend #1528

Closed danipaniii closed 1 year ago

danipaniii commented 2 years ago

Closes #1495 Implementing the DynamicallyServiceObserver to register all the available services (e.g. Prometheus, Jaeger, LogPreloader) and their current state enabled/disabled. In the UI when clicking the agents name (on the status page) a dialog window opens with a data table, listing all the services and their current state enabled/disabled. Currently the states are being shown as disabled buttons with the labes (enabled/disabled) to show the user the current state. In the future there is the possibilty to implement a feature to activate those buttons and let the user active/deactivate a service by a simple button click.

This change is Reviewable

codecov[bot] commented 2 years ago

Codecov Report

Merging #1528 (0c51ee7) into master (4ae7a26) will decrease coverage by 0.72%. The diff coverage is 13.33%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1528 +/- ## ============================================ - Coverage 78.64% 77.92% -0.72% - Complexity 2271 2285 +14 ============================================ Files 232 235 +3 Lines 7438 7563 +125 Branches 887 902 +15 ============================================ + Hits 5849 5893 +44 - Misses 1219 1302 +83 + Partials 370 368 -2 ``` | [Impacted Files](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT) | Coverage Δ | | |---|---|---| | [.../src/main/java/com/mindprod/jarcheck/JarCheck.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvY29tL21pbmRwcm9kL2phcmNoZWNrL0phckNoZWNrLmphdmE=) | `0.00% <0.00%> (ø)` | | | [...service/DynamicallyActivatableServiceObserver.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL3NlbGZtb25pdG9yaW5nL3NlcnZpY2UvRHluYW1pY2FsbHlBY3RpdmF0YWJsZVNlcnZpY2VPYnNlcnZlci5qYXZh) | `81.82% <81.82%> (ø)` | | | [.../propertysources/http/HttpPropertySourceState.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL2NvbmZpZy9wcm9wZXJ0eXNvdXJjZXMvaHR0cC9IdHRwUHJvcGVydHlTb3VyY2VTdGF0ZS5qYXZh) | `77.86% <100.00%> (+0.17%)` | :arrow_up: | | [...ot/core/service/DynamicallyActivatableService.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL3NlcnZpY2UvRHluYW1pY2FsbHlBY3RpdmF0YWJsZVNlcnZpY2UuamF2YQ==) | `83.72% <100.00%> (+0.79%)` | :arrow_up: | | [...elot/config/model/exporters/CompressionMethod.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb25maWcvc3JjL21haW4vamF2YS9yb2Nrcy9pbnNwZWN0aXQvb2NlbG90L2NvbmZpZy9tb2RlbC9leHBvcnRlcnMvQ29tcHJlc3Npb25NZXRob2QuamF2YQ==) | `100.00% <0.00%> (ø)` | | | [.../ocelot/core/metrics/system/GCMetricsRecorder.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL21ldHJpY3Mvc3lzdGVtL0dDTWV0cmljc1JlY29yZGVyLmphdmE=) | `72.95% <0.00%> (+0.82%)` | :arrow_up: | | [...ot/core/instrumentation/AsyncClassTransformer.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL2luc3RydW1lbnRhdGlvbi9Bc3luY0NsYXNzVHJhbnNmb3JtZXIuamF2YQ==) | `85.45% <0.00%> (+0.91%)` | :arrow_up: | | [...ocelot/core/exporter/OtlpTraceExporterService.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL2V4cG9ydGVyL090bHBUcmFjZUV4cG9ydGVyU2VydmljZS5qYXZh) | `66.67% <0.00%> (+1.80%)` | :arrow_up: | | [...t/ocelot/config/validation/PropertyPathHelper.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb25maWcvc3JjL21haW4vamF2YS9yb2Nrcy9pbnNwZWN0aXQvb2NlbG90L2NvbmZpZy92YWxpZGF0aW9uL1Byb3BlcnR5UGF0aEhlbHBlci5qYXZh) | `78.89% <0.00%> (+2.22%)` | :arrow_up: | | [...elot/core/exporter/OtlpMetricsExporterService.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL2V4cG9ydGVyL090bHBNZXRyaWNzRXhwb3J0ZXJTZXJ2aWNlLmphdmE=) | `69.49% <0.00%> (+3.64%)` | :arrow_up: | | ... and [1 more](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1528/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT) | |
danipaniii commented 1 year ago

Everything seems to be working as expected. @heiko-holz in our last conversation we talked about the badge that is being shown in the status view and the badge overlapping the buttons. The badge doesn't overlap with the buttons anymore, but slightly overlaps the agents service name, if the name is very long (See screenshot)

badge_longname

Since we talked about improving the styling in that part, I was wondering if we should open a new Issue to resolve this or if we should at least solve the overlapping with the badge and the name at the moment.

heiko-holz commented 1 year ago

Hey @danipaniii, good catch! I just fixed this by reducing the max-width for the service name.

Anyhow, we can open an issue after this PR to improve the code and style of the Agent Status Table.