search

inspectIT / inspectit-ocelot

inspectIT Ocelot - Java agent for collecting application performance, tracing and behavior data
http://www.inspectit.rocks/
Apache License 2.0
204 stars 69 forks source link

Closes #1531 - Change base URL for the documentation website, when working on the documentation #1532

Closed danipaniii closed 1 year ago

danipaniii commented 1 year ago

Closes #1531

Now the base URL for starting the documentation website is set to xxx/inspectit-ocelot/docs/next/doc1, so when working on the documentation you don't have to always manually go to that URL.

This change is Reviewable

danipaniii commented 1 year ago

Dear Sascha, I think you commented on the wrong PR :D But to answer your question: In the current master branch it is still possible to see the agent-config eventhough the agent commands are not enabled. Once PR 1528 is being merged to the master branch, this will not be possible anymore. Kind Regards Daniel

danipaniii commented 1 year ago

Dear Sascha, I have to correct myself, indeed for the agent-config it is not necessary to have the agent commands enabled. I will update the documentation. Also with the PR mentioned above, this will not be implemented, I must have mixed something up :D Thanks a lot! Kind Regards Daniel

heiko-holz commented 1 year ago

Hi @danipaniii, thanks for the pull request!

I realized that you branched off another feature branch for this pull request instead of inspectIT Ocelot master branch.

The only change this PR brings is the change in the index.html file.

I would recommend rebasing this branch to the master branch and only commit the update to the index.html file, and not the changes of other feature branches.