inspectIT / inspectit-ocelot

inspectIT Ocelot - Java agent for collecting application performance, tracing and behavior data
http://www.inspectit.rocks/
Apache License 2.0
204 stars 69 forks source link

Closes #1543 - Older Agent versions are no longer compatible with the config server from the release 2.2. #1544

Closed danipaniii closed 1 year ago

danipaniii commented 1 year ago

Fixing the incompatibility error with older agent versions and the config server from the release 2.2.0.


This change is Reviewable

danipaniii commented 1 year ago
version-code

Personally I am wondering if the if-condition at line 122 is necessary? Because by default log preloading, agent commands and the service states available are set to false and if they can't be fetched later in the try catch block at 140, they are not available.

heiko-holz commented 1 year ago

components/inspectit-ocelot-configurationserver-ui/yarn.lock line 0 at r5 (raw file): can you please delete your yarn.lock locally and build it fresh (via yarn install). I think the uploaded yarn.lock also contains npm stuff

heiko-holz commented 1 year ago

Hi @danipaniii , I think we still need line 122 it to see if serviceStatesAvailable, to use it further (see my other comments).

If we don't check for serviceStatesAvailable (see other comments), we are executing unnecessary try/catch blocks. Also, we need to retrieve logAvailable´ andagentCommandsEnabled` in a downward-compatible way (see my other comments)