search

inspectIT / inspectit-ocelot

inspectIT Ocelot - Java agent for collecting application performance, tracing and behavior data
http://www.inspectit.rocks/
Apache License 2.0
204 stars 69 forks source link

Closes #1546: [Bug] - Agent throws exception if logback config contains net.logstash.logback.encoder.LoggingEventCompositeJsonEncoder #1550

Closed heiko-holz closed 1 year ago

heiko-holz commented 1 year ago

Closes #1546

This change is Reviewable

codecov[bot] commented 1 year ago

Codecov Report

Merging #1550 (d09e837) into master (3152c9a) will decrease coverage by 0.05%. The diff coverage is n/a.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1550 +/- ## ============================================ - Coverage 78.28% 78.23% -0.05% + Complexity 2404 2402 -2 ============================================ Files 246 246 Lines 7909 7909 Branches 936 936 ============================================ - Hits 6191 6187 -4 - Misses 1303 1308 +5 + Partials 415 414 -1 ``` | [Impacted Files](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT) | Coverage Δ | | |---|---|---| | [...in/java/rocks/inspectit/ocelot/core/AgentImpl.java](https://codecov.io/gh/inspectIT/inspectit-ocelot/pull/1550?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=inspectIT#diff-aW5zcGVjdGl0LW9jZWxvdC1jb3JlL3NyYy9tYWluL2phdmEvcm9ja3MvaW5zcGVjdGl0L29jZWxvdC9jb3JlL0FnZW50SW1wbC5qYXZh) | `61.82% <0.00%> (-7.27%)` | :arrow_down: |
heiko-holz commented 1 year ago

inspectit-ocelot-config/src/main/java/rocks/inspectit/ocelot/config/model/instrumentation/rules/RuleTracingSettings.java line 100 at r3 (raw file):

Previously, heiko-holz (Heiko Holz) wrote…
Yes, actually this should have been fixed in the original PR of the auto tracing feature, but somehow I forgot. Gradle reminded me of this when I was building the `THIRD-PARTY-LICENSES.txt` :D

I reverted this and moved it to another issue: https://github.com/inspectIT/inspectit-ocelot/issues/1565