search

inspectIT / inspectit-ocelot

inspectIT Ocelot - Java agent for collecting application performance, tracing and behavior data
http://www.inspectit.rocks/
Apache License 2.0
204 stars 69 forks source link

Closes #1574: [Bug] - Span attributes not added when obfuscator is enabled #1575

Closed heiko-holz closed 1 year ago

heiko-holz commented 1 year ago

Closes #1574

This change is Reviewable

heiko-holz commented 1 year ago

inspectit-ocelot-core/src/main/java/rocks/inspectit/ocelot/core/exporter/OtlpTraceExporterService.java line 66 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…
I saw that code in three different places so far. Is it possible to move that into `otlp.getEndpoint()`? In that way we would have easily at a single place.

Yeah, good idea. I agree.

However, I'd first like to talk to you about the "http-padding" that I introduced.

heiko-holz commented 1 year ago

inspectit-ocelot-core/src/test/java/rocks/inspectit/ocelot/core/exporter/ExporterServiceIntegrationTestBase.java line 297 at r1 (raw file):

Previously, quandor (Jochen Just) wrote…
Those enclosing parenthesis are unnecessary, or am I missing something?

Thanks for spotting. I removed the redundant parentheses.