search

inspectdev / inspect-issues

Issue tracker for Inspect
22 stars 2 forks source link

Add support for different breakpoint types #61

Closed samholmes closed 3 years ago

samholmes commented 3 years ago

This is a feature request to add support for all of DevTool's breakpoint types: conditional breakpoint and logpoint. Currently, secondary clicking on a line number does nothing; I'd expect it to show options for the breakpoint type.

auchenberg commented 3 years ago

This should be handled as soon as context menu lands, https://github.com/inspectdev/inspect-issues/issues/53

auchenberg commented 3 years ago

Landed in next release.

samholmes commented 2 years ago

I am still not seeing this feature. I'm on macOS.

Screen Shot 2021-10-25 at 12 40 30 Screen Shot 2021-10-25 at 12 40 49
auchenberg commented 2 years ago

@samholmes Should be supported in the latest version. If you have a minified script you need to pretty print first.

Screen Shot 2021-10-26 at 9 08 36 AM

What kind of script are you debugging? Anything sourcemapped?

samholmes commented 2 years ago

@auchenberg Yes the script I'm debugging is sourcemapped. I'm debugging webpack output that has sourcemaps (devtool: 'cheap-source-map', in my webpack config). Why does sourcemapping affect the ability to set breakpoints in both the mapped version and the unmapped version (Only 'Add breakpoint' is a context menu option in the unmapped source code, and choosing it always opens a source mapped version of the file).