inspector-cochise / cochise

An audit tool for the apache webserver assisting on the BSI audit for the apache.
www.inspector-cochise.de
GNU General Public License v3.0
1 stars 0 forks source link

Find & Correct Error handling situations #39

Closed inspector-cochise closed 12 years ago

inspector-cochise commented 12 years ago

Especially situations like catch{SomeEvilExceptionIDontKnowWhatToCatchFor e) { throw new RuntimeException("I don't really know what happened.", e); }

i.e. do a search for RuntimeException over the full project and ensure correct use of that class.

Also don't forget to search for other (maybe strange) error handling.

(The parser should be mostly ok.)

inspector-cochise commented 12 years ago

partly done: the throw new RuntimeException thing has been done.

it would also be a good idea to search for printStackTrace(). I saw some cases where the handling was to print the StackTrace and the continue as nothing happened (bad idea since the original exception will be hard to identify)

even better (but a lot of work) would be to examine every single catch block...

inspector-cochise commented 12 years ago

Seems to be done.

-did the printStackTrace() search -did the catch-block search Even some less important cases have been overdone.