search

inspectorG4dget / AnonymousFeedback

1 stars 0 forks source link

Refactor getCourseFeedbacks database API function to circumvent unpacking error #46

Closed scriptbae closed 7 years ago

scriptbae commented 7 years ago

There's an immediately relevant issue in dbhandler.getCourseFeedbacks where a for loop attempts to unpack an 8-element list into 10 elements.

The problematic elements are those representing the start and end times of a section.

Upon inspection, these two problem values may not be consequential in the Professor view.

RFC: should these two values be preserved (which would require changes to the DB query in this function)?

cannotparse commented 7 years ago

Which two values?

scriptbae commented 7 years ago

@NuclearBanane the loop attempts to unpack startTime and endTime, but the SQL query which retrieves the data from the DB doesn't fetch those columns.

scriptbae commented 7 years ago

Function will be refactored to exclude the startTime and endTime fields in the response payload.