search

inspectorG4dget / AnonymousFeedback

1 stars 0 forks source link

Ensure that all `@tornado.web.asynchronous` methods finish #54

Closed scriptbae closed 7 years ago

scriptbae commented 7 years ago

There are currently a few endpoints -- mostly PUT/POST -- which, while they invoke side-effects, don't finish and return a response to the client.

This makes it impossible to evaluate the success or failure of a query client-side and to update the view to reflect this. It can also result in long-running function invocations client-side before a timeout is detected.

These methods should include calls to self.finish().

scriptbae commented 7 years ago

I'm implementing fixes for this progressively while inspecting backend.py for API response formats (which are used to complete #12).

scriptbae commented 7 years ago

Closed by PR #52.