search

inspera / blackbricks

Black for Databricks notebooks
MIT License
44 stars 9 forks source link

Upgrade black dependency to 24.4.2? #60

Closed vengroff closed 3 months ago

vengroff commented 3 months ago

Would it be possible to upgrade the version of black to 24.4.2 and release a new version? That way it would work in environments that have moved up versions of black for other reasons.

I'd be happy to submit a PR for for this and also include the dependabot issues #56 and #57 just to get everything up to the latest. Let me know if you'd be interested in a PR like this and I'll submit one.

bsamseth commented 3 months ago

Thanks for offering to submit a PR. There's a few manual steps still to push out a new release, so I just did it now. I just needed a kick in the ass to actually do it. 👍🏻

vengroff commented 3 months ago

Thanks for doing this right away!

I actually jumped the gun a bit before you did and forked https://github.com/vengroff/blackbricks/tree/master and updated black plus some other dependencies. I ended up updating more things because I'm hoping to use this in an environment that is currently quite up to date on most things.

This morning I pulled in your upstream changes. The fork is at https://github.com/vengroff/blackbricks/tree/master

I'm not sure what all your manual steps are, but I did run this against the test notebook in the repo and it worked. Let me know if this would be a worthwhile pull request.

bsamseth commented 3 months ago

Thanks for the effort :) However, no. I won't touch more dependencies than necessary at this point. See #39 which has a longer answer to essentially the same problem.

vengroff commented 3 months ago

Ok. Thanks for the explanation. And don't worry. It really was not too much effort.