inspheric / nova-indicator-field

A colour-coded indicator field for Laravel Nova
129 stars 10 forks source link

Nova 4 Support #16

Open stefblokdijk opened 2 years ago

stefblokdijk commented 2 years ago

Since Nova 4 uses Vue 3, the Indicators weren't rendering on the latest Nova version.

This PR updates the package to support Nova 4 (just for the project i'm using it on) and likely won't be compatible with previous Nova versions. That is why i'd suggest to release this eventually as a v2 of this package with instructions how Nova 1 - 3 users should install v1 on their project.

Besides the Nova 4 / Vue 3 update, i've also made minor changes to the code styling to match other packages i've came across and a small CSS change to improve spacing between the indicator and the text. Feel free to revert these smaller changes if they don't match your workflow.

This PR is not 100% release ready since i've not

kitbs commented 2 years ago

Hi @stefblokdijk Thank you so much for making a start on this!! I will review it as soon as I can once you've finished.

stefblokdijk commented 2 years ago

I've updated the screenshots and tested the FormField. Feel free to review now

flatcapco commented 2 years ago

Hey is there any chance this will be released soon please? Thank you

coopers98 commented 1 year ago

Hulloooo? Need these updates please

Wefabric-Kevin commented 1 year ago

Specifically for Nova 4, you can also use this fork: khalin/nova4-indicator-field, for those interested in the meantime.