Make m_join0.cpp use /PARTALL instead of /join 0

inspircd / inspircd-contrib

Third-party InspIRCd module repository.

https://www.inspircd.org

66 stars 72 forks source link

Make m_join0.cpp use /PARTALL instead of /join 0 #171

Closed KoraggKnightWolf closed 5 years ago

KoraggKnightWolf commented 5 years ago

The m_join0 module uses /join 0 to part all channels. This fork makes it work using the command /partall instead which is more intuitive and less likely to be used to trick newbies into parting all channels by mistake.

Regards,

Koragg

jlu5 commented 5 years ago

..I'm pretty sure the point of this module was for RFC2812 compatibility, which specifies /join 0? So I don't think this is correct.

KoraggKnightWolf commented 5 years ago

I reverted the changes to the m_join.cpp module and instead made an m_partall.cpp causing /partall to behave as /join 0 for those who might prefer it this way. Also almost no IRCd sticks to the RFC's and the changes are confirmed to work on InspIRCd 2.0.27.

Regards,

Koragg

Robby- commented 5 years ago

~~You could have just used m_alias and aliased the PARTALL command instead.~~ Or even added PARTALL to the m_join0 module as an additional command instead of duplicating this module, like so: if (validated && ((command == "JOIN" && (parameters.size() == 1) && parameters[0] == "0") || command == "PARTALL"))

Robby- commented 5 years ago

This PR has become completely scuffed now.

KoraggKnightWolf commented 5 years ago

Closed due to my own mistake of not creating a branch for my own customizations and clogging up the PR. Sincerest apologies it was not intentional.

Regards,

Koragg