inspircd / inspircd-contrib

Third-party InspIRCd module repository.
https://www.inspircd.org
66 stars 72 forks source link

Fix sslmodeuser to allow conn_umodes to set it on connect. #189

Closed genius3000 closed 5 years ago

genius3000 commented 5 years ago

The UserCertificateRequest method primarily used doesn't work when conn_umodes tries to set the mode as the underlying ExtItem does not yet exist. We can work around that when the user is local (conn_umodes only acts on local users) by using the SocketCertificateRequest which will exist this early.
While the majority of mode setting will be user on themselves which will call the Socket request each time, this keeps the messaging check and any possible remote user checking to the simpler ExtItem request.

Resolves #184.