Closed genius3000 closed 5 years ago
is there any reason this module needs to be first? Isn't being prioritised in front of allowinvite enough?
Likely not, so yeah just in front of allowinvite should be fine. Is it generally better to keep prioritization specific when possible? Only a few other modules use this hook so first seemed good for a deny rule.
Is it generally better to keep prioritization specific when possible?
Yes, because if two modules hook to front the prioritiser will get into a loop until it eventually gives up
Specifically, m_allowinvite returns ALLOW so we need to run first to be able to return DENY.
Resolves #191.