search

inspircd / inspircd-contrib

Third-party InspIRCd module repository.
https://www.inspircd.org
66 stars 72 forks source link

non-client tags aren't included in chanhistory #260

Closed rgraff closed 3 years ago

rgraff commented 3 years ago

I'm using chanhistory and customtags modules (v3.9.0). When the history is sent, it includes tags like msgid but not the vendor tags. I've added some debug logging to chanhistory and when the HistoryItem is created, the tags_out in MessageDetails does not have the vendor tags.

@SadieCat said "thats a known issue. non-client tags aren't stored due to limitations in how the tag api in v3 works" but that she could fix it "just for the customtags module"

SadieCat commented 3 years ago

https://github.com/inspircd/inspircd-contrib/compare/master...SadieCat:customtags-chanhistory is untested but should work, can you test it?

rgraff commented 3 years ago

I tested your branch. The tags do get added to the HistoryItem but don't get added to the message when the history is sent. With this change to chanhistory it works as expected.

SadieCat commented 3 years ago

Ah I missed marking the tag as being processable. The new version in that branch should fix this without any changes to chanhistory.

rgraff commented 3 years ago

Testing new commits... In the new OnProcessTag IS_LOCAL(user) returns false so the tags don't appear when the history is sent.

SadieCat commented 3 years ago

Does it work if you remove the IS_LOCAL check?

rgraff commented 3 years ago

Confirmed. If I remove the IS_LOCAL check, it works as expected.