Reference to table in Service Metadata test

inspire-eu-validation / download-service

Abstract Test Suite for the Technical Guidance for the implementation of INSPIRE Download Services

Creative Commons Zero v1.0 Universal

2 stars 4 forks source link

Reference to table in Service Metadata test #80

Closed heidivanparys closed 6 years ago

heidivanparys commented 6 years ago

The Service Metadata test references Table 4 in the Technical Guidelines. Isn't this a mistake in the TG? Shouldn't this be Table 19 instead? And the test description updated, with a note regarding this mistake?

cportele commented 6 years ago

Indeed. I tagged this for discussion in the MIG-T subgroup (although this looks like an obvious bug and likely just need to be fixed).

michellutz commented 6 years ago

I agree. This is a bug in the TG and should be fixed there and in the ATS.

Then we of course also need to check that the ETS implementation is using the correct table / mapping.

michellutz commented 6 years ago

[2017.4 meeting 2018-02-15] It was agreed that this should be fixed in the ATS (see #82) and it should be checked that the ETS implementation is using the correct table / mapping (action on me).

michellutz commented 6 years ago

From what I can tell, ets-repository/service/ds-wfs-pre-defined-soapui-project.xml seems to be using table 19. @jonherrmann could you please confirm? The only change that would need to be made there is to also update the reference to table 19 in line 4924.

jonherrmann commented 6 years ago

The ETS is based on this ATC: http://inspire.ec.europa.eu/id/ats/download-service/3.1/wfs-pre-defined/service-metadata . Mainly the Contextual XPath references were used, taken from table 19.

So yes, I will create a PR in the ets-repository for changing the table reference.

PeterParslow commented 6 years ago

See also https://github.com/inspire-eu-validation/download-service/issues/81 - the last row of Table 19 may be wrong.

michellutz commented 6 years ago

[2017.4 meeting 2018-03-16] The proposed change has been implemented in the relevant ATS and ETS.